Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Pitfall: using add_system instead of add_startup_system? #41

Closed
ramirezmike opened this issue Apr 2, 2021 · 1 comment · Fixed by #33
Closed

Common Pitfall: using add_system instead of add_startup_system? #41

ramirezmike opened this issue Apr 2, 2021 · 1 comment · Fixed by #33
Labels
C-enhancement New content that isn't covered already S-pitfalls Content in the Pitfalls chapter S-programming Core bevy APIs / programming patterns

Comments

@ramirezmike
Copy link

Mixing up add_system and add_startup_system can cause bugs or performance issues that might not be easy to track down for beginners. This might be a good thing to point out in the system function common pitfall page?

@inodentry inodentry added C-enhancement New content that isn't covered already S-pitfalls Content in the Pitfalls chapter S-programming Core bevy APIs / programming patterns labels Apr 2, 2021
@inodentry
Copy link
Contributor

I decided to address this directly in the "Bevy Programming > Basics > Systems" page, alongside mentioning the app builder (as suggested in #40).

I think this is a better place for it. It will lead to more visibility. The "system function pitfall" page you linked is for when people get compiler errors with adding systems, so it didn't feel right to put it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New content that isn't covered already S-pitfalls Content in the Pitfalls chapter S-programming Core bevy APIs / programming patterns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants