Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Guide 0.13 - Capsule::depth -> Capsule3d::half_length #989

Closed
afonsolage opened this issue Feb 17, 2024 · 1 comment · Fixed by #993
Closed

Migration Guide 0.13 - Capsule::depth -> Capsule3d::half_length #989

afonsolage opened this issue Feb 17, 2024 · 1 comment · Fixed by #993
Labels
A-Migration Guides C-Correction A typo, problem or factual issue in what we've written

Comments

@afonsolage
Copy link
Contributor

afonsolage commented Feb 17, 2024

So at the end, the old Capsule from bevy_render::mesh::shape is totally different from Capsule3d. I don't think the deprecation warning is enough. Maybe should we explicit add something like bellow?

  • bevy_render::mesh::Capsule is deprecated use bevy_math::primitives::dim3::Capsule3d instead;
  • bevy_render::mesh::Cylinder is deprecated use bevy_math::primitives::dim3::Cylinder instead;
  • bevy_render::mesh::Icosphere is deprecated use bevy_math::primitives::dim3::Sphere instead;
    ..etc
@alice-i-cecile
Copy link
Member

Yeah, that seems sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Migration Guides C-Correction A typo, problem or factual issue in what we've written
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants