Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async-Executor v1.9.0 Selected by Cargo Locks up the engine #12044

Closed
dt665m opened this issue Feb 22, 2024 · 2 comments
Closed

Async-Executor v1.9.0 Selected by Cargo Locks up the engine #12044

dt665m opened this issue Feb 22, 2024 · 2 comments
Labels
A-Tasks Tools for parallel and async work C-Dependencies A change to the crates that Bevy depends on

Comments

@dt665m
Copy link

dt665m commented Feb 22, 2024

Bevy version

Bevy 0.12.1

[Optional] Relevant system information

macOs Sonoma

What you did

Shared a Project without Cargo.lock checked in. A new Cargo.lock resolved by cargo Resolves to Async-Executor 1.9.0, which locks up the game at the very start. This is very hard to bisect when many things are different in Cargo.lock

Additional information

Either something changed with async-executor that is more than a small bump (not exactly MINOR in semver) or perhaps there is a bug. Maybe bevy can lock the dependency.

Temporary Fix

For those who might also run into this, we are explicitly pinning async-executor to 1.8.0 in our own Cargo.

@dt665m dt665m added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 22, 2024
@mockersf mockersf added this to the 0.13.1 milestone Feb 22, 2024
@mockersf mockersf added A-Tasks Tools for parallel and async work C-Dependencies A change to the crates that Bevy depends on and removed C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 22, 2024
@james7132 james7132 added the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Feb 22, 2024
@james7132
Copy link
Member

async-executor 1.9.0 has been yanked for now. New builds shouldn't be pulling it anymore. Going to continue to investigate why this happened, as this was a bug. In retrospect, having been working on both projects, I should have validated changes to async-executor worked with Bevy.

@james7132 james7132 removed the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Feb 22, 2024
@james7132 james7132 removed this from the 0.13.1 milestone Feb 22, 2024
@james7132
Copy link
Member

Closing this out for now as async_executor has yet to publish a new version, but the issue has been fixed upstream. A new version has not been published due to a major regression in performance due to higher contention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tasks Tools for parallel and async work C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Development

No branches or pull requests

3 participants