Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pipeline statistics with bevy_dev_tools #12541

Open
alice-i-cecile opened this issue Mar 17, 2024 · 2 comments
Open

Integrate pipeline statistics with bevy_dev_tools #12541

alice-i-cecile opened this issue Mar 17, 2024 · 2 comments
Labels
A-Dev-Tools Tools used to debug Bevy applications. A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Mar 17, 2024

What problem does this solve or what need does it fill?

Added in #9135, this is fundamentally a tool used by developers to inspect their game.

It should be integrated with bevy_dev_tools for:

  • discoverability
  • code quality
  • a shared API to configure it

What solution would you like?

Once #9135 is merged, add an integration, adding an on-by-default feature flag. We can probably combine this with the frame-time tool: @matiqo15 and I agree that this sort of timing / performance information should be integrated and displayed cohesively.

If #12427 is also merged, implement the standard dev tools abstraction for it as well.

What alternatives have you considered?

Initially I thought it might be correct to move the initial code to bevy_dev_tools entirely. However:

a) it's tightly integrated with the rest of the renderer
b) it doesn't contain any native ways to display this information, that might be toggled or configured like the other dev tools

We could also consider moving this code to bevy_diagnostics, but similar problems arise. It also creates a painful dependency from bevy_render to bevy_diagnostics, when we want the dependency to flow the opposite direction, for both compile time and architectural reasons.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Dev-Tools Tools used to debug Bevy applications. labels Mar 17, 2024
@alice-i-cecile alice-i-cecile changed the title Move pipeline statistics into bevy_dev_tools Integrate pipeline statistics with bevy_dev_tools Mar 17, 2024
@matiqo15
Copy link
Member

I believe this should be in the bevy_diagnostic as it collects data. But some sort of visualization of this data should be in the bevy_dev_tools

@alice-i-cecile
Copy link
Member Author

We could also consider moving this code to bevy_diagnostics, but similar problems arise. It also creates a painful dependency from bevy_render to bevy_diagnostics, when we want the dependency to flow the opposite direction, for both compile time and architectural reasons.

Chewed on this choice too :) I've since changed my mind about what the best course of action is here and I've updated the original issue to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Dev-Tools Tools used to debug Bevy applications. A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Development

No branches or pull requests

2 participants