Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple skybox and envmap for use in examples #13632

Open
alice-i-cecile opened this issue Jun 2, 2024 · 3 comments · May be fixed by #13671
Open

Add a simple skybox and envmap for use in examples #13632

alice-i-cecile opened this issue Jun 2, 2024 · 3 comments · May be fixed by #13671
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@alice-i-cecile
Copy link
Member

Adding a skybox to the motion_blur example would be nice

I agree. I tried this out, but frankly it looks awful with the skyboxes we have available in tree. It would be nice if we had a simpler sky-and-clouds skybox and envmap.

Originally posted by @aevyrie in #13617 (comment)

This should be easy enough, but we can only use permissively licensed assets.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Jun 2, 2024
@andristarr
Copy link
Contributor

Are we okay with CC-BY licensed assets? If yes, where should we credit the author of the skybox asset?

@alice-i-cecile
Copy link
Member Author

CC-BY is great: add it to CREDITS.md.

@andristarr andristarr linked a pull request Jun 4, 2024 that will close this issue
@aevyrie
Copy link
Member

aevyrie commented Jun 5, 2024

As noted in #13671 (and my original comment):

Ideally we would also have an envmap, so the lighting matches the skybox. You can use https://github.com/pcwalton/gltf-ibl-sampler-egui to generate skyboxes and specular/diffuse envmaps from hdr skyboxes you find online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants