Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CubicCurve is missing serde support #13852

Open
torsteingrindvik opened this issue Jun 14, 2024 · 0 comments · May be fixed by #13864
Open

CubicCurve is missing serde support #13852

torsteingrindvik opened this issue Jun 14, 2024 · 0 comments · May be fixed by #13864
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Enhancement A new feature D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@torsteingrindvik
Copy link
Contributor

What problem does this solve or what need does it fill?

CubicCurve docs.

I had a networked API which I wanted to send a CubicCurve across but serde derives were missing.

What solution would you like?

Add the necessary conditional derives like other structs e.g. CompassQuadrant from the same crate.

What alternative(s) have you considered?

My workaround was to make my own struct which had the necessary data to reconstruct the CubicCurve on the other side, but it would be more straightforward not to have to do that.
@torsteingrindvik torsteingrindvik added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Jun 14, 2024
@mweatherley mweatherley added the A-Math Fundamental domain-agnostic mathematical operations label Jun 14, 2024
@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed S-Needs-Triage This issue needs to be labelled labels Jun 15, 2024
@mnmaita mnmaita linked a pull request Jun 15, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Enhancement A new feature D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds serde derives to CubicCurve behind feature flag mnmaita/bevy
3 participants
@mweatherley @janhohenheim @torsteingrindvik