Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp3 cargo feature causes iOS apps to get rejected from app store #3145

Closed
cart opened this issue Nov 18, 2021 · 3 comments
Closed

mp3 cargo feature causes iOS apps to get rejected from app store #3145

cart opened this issue Nov 18, 2021 · 3 comments
Labels
A-Audio Sounds playback and modification C-Bug An unexpected or incorrect behavior S-Blocked This cannot move forward until something else changes

Comments

@cart
Copy link
Member

cart commented Nov 18, 2021

Quoting @HackerFoo from discord:

Heads up, using the mp3 Bevy feature will cause your iOS app to get rejected because minimp3 depends on slice_deque which uses an internal API for memory allocation.

@Ixentus

Rodio has an extra backend "Symphonia" which can also do mp3. Should be easy to enable if you need it

Sounds like we should evaluate Symphonia as a backend.

@cart cart added C-Bug An unexpected or incorrect behavior A-Audio Sounds playback and modification labels Nov 18, 2021
@alice-i-cecile
Copy link
Member

Ping @tesselode, who was also investigating Symphonia for the kira audio crate that the community has largely been using for audio.

@HackerFoo
Copy link
Contributor

The offending symbols were: _mach_vm_allocate, _mach_vm_deallocate, and _mach_vm_remap.

I worked around this by converting to .ogg and replacing the mp3 feature with vorbis.

@mockersf
Copy link
Member

mockersf commented Jun 11, 2023

mp3 now use symphonia instead of minimp3 and should be accepted in the App Store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Audio Sounds playback and modification C-Bug An unexpected or incorrect behavior S-Blocked This cannot move forward until something else changes
Projects
Status: Done
Development

No branches or pull requests

4 participants