Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable winit "default" feature #6326

Open
JMS55 opened this issue Oct 21, 2022 · 5 comments
Open

Enable winit "default" feature #6326

JMS55 opened this issue Oct 21, 2022 · 5 comments
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Enhancement A new feature

Comments

@JMS55
Copy link
Contributor

JMS55 commented Oct 21, 2022

What problem does this solve or what need does it fill?

I'm not sure why it was disabled in the first place. But enabling it brings Wayland by default, which fits in much better with my system, and is a more modern and potentially lower-latency/faster API.

What solution would you like?

Enable winit "default" feature in bevy_winit.

What alternative(s) have you considered?

If the intention was to have x11 as the default, at least add "winit/wayland-csd-adwaita" to bevy_winit's "wayland" feature, as without it, on desktops without SSD, the CSD looks pretty bad.

@JMS55 JMS55 added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Oct 21, 2022
@VitalyAnkh
Copy link
Contributor

VitalyAnkh commented Oct 21, 2022

Disabling winit default features is for reducing application size. And if any applications want some winit features, they could just enable them.

@irate-devil
Copy link
Contributor

I think it's reasonable to enable Wayland by default, but unfortunately Wayland on Nvidia GPUs doesn't play nice yet with winit/wgpu.
This would need to have some fix/workaround first.

@dataphract dataphract added A-Windowing Platform-agnostic interface layer to run your app in and removed S-Needs-Triage This issue needs to be labelled labels Oct 21, 2022
@mattfbacon
Copy link

I also would like Wayland enabled by default. It's 2023 and more and more distros are adopting Wayland by default. XWayland is a bad experience and no modern app should rely on it.

@mockersf
Copy link
Member

a quick look at Firefox telemetry shows that wayland is around 15% of its user base

@mattfbacon
Copy link

I wonder how many are using XWayland because they didn't set MOZ_ENABLE_WAYLAND=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Enhancement A new feature
Projects
None yet
Development

No branches or pull requests

6 participants