Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom songs no longer work when outputting to midi device #40

Closed
KieranGreenwood opened this issue Nov 16, 2023 · 1 comment
Closed

Comments

@KieranGreenwood
Copy link

Steps to reproduce:

  1. enable midi output to piano
  2. load custom song
  3. play

The animation plays to the first note and crashes before it starts.

This behavior only seems to happen for custom songs that try to output to midi device.

  • The default preloaded songs work and output to both pc speakers and midi device speakers.
  • Custom songs work and output via pc speakers just not midi.

Once a custom song has crashed the app, all other types of song no longer work until the app is refreshed.

The following error logs as it crashes:

main.min.js:1 Uncaught TypeError: Cannot read properties of undefined (reading 'timestamp')
    at t.playSustain (main.min.js:1:821556)
    at t.playNotesTick (main.min.js:1:819037)
    at t.playTick (main.min.js:1:818129)
    at main.min.js:1:820196
@Bewelge
Copy link
Owner

Bewelge commented Nov 17, 2023

Thanks for the notice! It was caused by songs that contain no sustain events, since I recently added sustain to MIDI out. Should be fixed now.

@Bewelge Bewelge closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants