Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something about loose LuaUI files in default engine installation #1483

Open
sprunk opened this issue Apr 30, 2024 · 0 comments
Open

Do something about loose LuaUI files in default engine installation #1483

sprunk opened this issue Apr 30, 2024 · 0 comments

Comments

@sprunk
Copy link
Collaborator

sprunk commented Apr 30, 2024

The engine installation comes with a bunch of loose LuaUI files (these https://github.com/beyond-all-reason/spring/tree/BAR105/cont/LuaUI ).

This presents two problems:

  • games rely on those files, which is fragile because they are undocumented and just happen to work. But players can just delete or overwrite them etc., it's just a ticking distribution bomb. They should be in some sort of basecontent-level archive for checksum etc.
  • many of these files are of very low quality. So just dumping them in an archive would waste a good opportunity to improve them.
  • it's also an opportunity to make it more newbie-dev friendly. Apparently the loose files are not enough for an empty mod to recognize a widget placed in ./luaui/widgets out of the box, which is bad.

The first task here is probably to make sure that existing games won't break if we touch these files. Make PRs to games so they have a local copy, or figure out what's safe to modify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant