Deprecated: Add balance mode split one chevs (Updated) #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jauggy
changed the title
jauggy
commented
Apr 9, 2024
| @@ -213,17 +213,14 @@ defmodule Teiserver.Game.BalancerServer do | |||
| |> Enum.map(fn userid -> | |||
| %{ | |||
| userid => | |||
| BalanceLib.get_user_balance_rating_value(userid, rating_type) | |||
| |> fuzz_rating(opts[:fuzz_multiplier]) | |||
| BalanceLib.get_user_rating_rank(userid, rating_type, opts[:fuzz_multiplier]) | |||
| } | |||
There was a problem hiding this comment.
So before it would iterate and call another function per user to get the rating. I thought it was ok because it uses a cache. I'm doing the same thing but now adding on rank and name, which is also cached.
If you can think of a better a solution...
jauggy
changed the title
|
As requested I've moved the changes to the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218
See issue ticket for details and test instructions.
Incorporating changes suggested by geekingfrog from previous PR.
Dependency to Account module has been removed from the split one chevs balance algorithm. However, inside balancer_server there is a function that iterates over user ids and fetches user information. Previously this information was only rating. Now it includes name and rank. While in code this looks like a db call, it wouldn't be in production because it uses a cache after the data is fetched once. It would be fetched once during login.
loser_picks (written by Teifion) still has a dependency to Teiserver.Account and the reason why units tests pass is because Teifion is using
which I think sets up a connection to the database during the test. I am not confident to change this module but can raise a ticket if needed. But as stated earlier, in production it would be using the cache not a db call.