Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application can't start when discord is unavailable #237

Open
p2004a opened this issue Mar 27, 2024 · 3 comments
Open

Application can't start when discord is unavailable #237

p2004a opened this issue Mar 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@p2004a
Copy link
Contributor

p2004a commented Mar 27, 2024

When Discord times out, is unavailable etc, teiserver can't start, crashes, and of course disabling Discord integration is non trivial and requires recompilation, thus Discord is a critical startup dependency for teiserver which is pretty much unacceptable.

I'm not sure what is the behavior when discord suddenly has outage when teiserver is already running.

@L-e-x-o-n L-e-x-o-n added the bug Something isn't working label Apr 7, 2024
@StanczakDominik
Copy link
Collaborator

Closed by #281

@p2004a
Copy link
Contributor Author

p2004a commented Jun 4, 2024

@StanczakDominik Is it actually fixing this issue? Is the code rewritten so that when discord is enabled in configuration, application doesn't crash when discord service is unavailable?

@StanczakDominik
Copy link
Collaborator

Ah, fair - I thought that was within the scope of that PR. Thanks for keeping me honest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants