You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On Windows (XP SP2, Strawberry 5.16.2, should not matter), t/ack-match.t failed for me with Out of memory error. This is because ack searches the stdout.log file as it is written into the build dir, during the 5th test: run_ack( '--match', 'Sue' );
This patch is a (silly) workaround, a better approach for a fix might be to tell the test instance of ack to ignore all/some .logfiles.
--- Util.pm.original.ack-2.10 Tue Sep 24 23:35:58 2013
+++ Util.pm Thu Oct 3 11:33:44 2013
@@ -178,8 +178,15 @@
if ( is_windows() ) {
require Win32::ShellQuote;
# Capture stderr & stdout output into these files (only on Win32).
- my $catchout_file = 'stdout.log';
- my $catcherr_file = 'stderr.log';
+
+ # Put into parent of build dir, because build dir is searched by
+ # ack tests. Test 5 in ack-match.t:
+ # run_ack( '--match', 'Sue' );
+ # can fail with "Out of memory" or fill storage volume -
+ # Test ack reads stdout.log, appending a message for every read line to
+ # stdout.log, filling up both storage and memory.
+ my $catchout_file = '../stdout.log';
+ my $catcherr_file = '../stderr.log';
open(SAVEOUT, ">&STDOUT") or die "Can't dup STDOUT: $!";
open(SAVEERR, ">&STDERR") or die "Can't dup STDERR: $!";
@@ -199,6 +206,8 @@
close SAVEERR;
@stdout = read_file($catchout_file);
@stderr = read_file($catcherr_file);
+ unlink $catchout_file;
+ unlink $catcherr_file;
}
else {
my ( $stdout_read, $stdout_write );
The text was updated successfully, but these errors were encountered:
On Windows (XP SP2, Strawberry 5.16.2, should not matter),
t/ack-match.t
failed for me withOut of memory
error. This is because ack searches thestdout.log
file as it is written into the build dir, during the 5th test:run_ack( '--match', 'Sue' );
This patch is a (silly) workaround, a better approach for a fix might be to tell the test instance of ack to ignore all/some
.log
files.The text was updated successfully, but these errors were encountered: