Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Feature gates are confusing #107

Closed
Xuanwo opened this issue Jun 15, 2021 · 2 comments · Fixed by #109
Closed

Feature gates are confusing #107

Xuanwo opened this issue Jun 15, 2021 · 2 comments · Fixed by #109
Labels
enhancement New feature or request

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Jun 15, 2021 •
edited

Only CreateDir is simulated, but all operations are affected.

We need to check features everywhere.
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jun 15, 2021

Maybe we need to extract features into another field instead of at the operation level.

@Xuanwo Xuanwo changed the title FeatureGates is confusing Feature gates is confusing Jun 15, 2021
@Xuanwo Xuanwo added the enhancement New feature or request label Jun 15, 2021
@JinnyYi JinnyYi mentioned this issue Jun 15, 2021
Closed
14 tasks
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jun 17, 2021

How about removing all operation level features and use global feature instead:

  • VirtualDir
  • VirtualLink
  • VirtualObjectMetadata

@Xuanwo Xuanwo linked a pull request Jun 17, 2021 that will close this issue
GSP-109: Redesign Features #109
Merged
@Xuanwo Xuanwo changed the title Feature gates is confusing Feature gates are confusing Jun 21, 2021
@zu1k zu1k mentioned this issue Jun 30, 2021
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GSP-109: Redesign Features beyondstorage/specs
1 participant
@Xuanwo