gives overrides options higher priority to the payload

[vboulaye]

Hello,
I am trying to use sapper-httpclient in a project of mine, but I need to set an Authorization header.

The override() method looks like a nice place to do this, and it works fine for all the GET calls:

create()
 .endpoint('https://myserver.com/')
 .override({
      headers: {
        'Authorization': 'Basic ' + Buffer.from(user.username + ":" + user.password).toString('base64'),
      },
    })
 .get()

But when I set a payload() in a POST or PUT calls, it overrides all the headers with a 'Content-Type': 'application/json' and I have no way to change this.

In order to fix this, I tried switching the payload and overrides during the merge into the request options object.

[antony]

Well spotted! I don't use headers much myself so I've not run into this.

I think the correct solution to this is proper header support (see commit below), and I've added some tests around the new .headers() method.

Released as 3.6.0

5d1880b

[vboulaye]

Yes, it is better with a specific method dedicated to headers (with the override workaround I had to repeat the Accept/Content-type header)
thanks a lot!