Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

parse perPage prop #32

Merged
merged 3 commits into from Jun 2, 2020
Merged

parse perPage prop #32

merged 3 commits into from Jun 2, 2020

Conversation

jokin
Copy link
Contributor

@jokin jokin commented Jun 1, 2020

Fixes #31

antony
antony suggested changes Jun 1, 2020
View reviewed changes
Copy link
Member

@antony antony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think maybe you're overthinking it though. Let me know what you think

src/Carousel.svelte Outdated Show resolved Hide resolved
@jokin
Copy link
Contributor Author

jokin commented Jun 2, 2020 •
edited

I, do you have the chance to review this so I can base another pull request from here?

@antony antony merged commit bec33ff into beyonk-group:master Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antony antony antony requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perPage attribute does not work
2 participants
@jokin @antony