Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😶‍🌫️ Adding CSRGraph to StaticGraph Abstraction #100

Open
nithinmanoj10 opened this issue Jan 16, 2024 · 0 comments · May be fixed by #112
Open

😶‍🌫️ Adding CSRGraph to StaticGraph Abstraction #100

nithinmanoj10 opened this issue Jan 16, 2024 · 0 comments · May be fixed by #112
Assignees
Labels
future-release Tasks that will be taken up for a future release

Comments

@nithinmanoj10
Copy link
Contributor

As of now the graph abstraction in STGraph has the following "base" classes

  1. STGraphBase
  2. StaticGraph
  3. DynamicGraph

StaticGraphand DynamicGraph inherits from STGraphBase. Whereas NaiveGraph, PCSRGraph and GPMAGraph inherits from DynamicGraphs.

However StaticGraph is not entirely serving the purpose of a base class, since we are using CSR within the class and implementing the graph class.

Solution
A solution would be to create a class named CSRGraph that inherits from StaticGraph. This also enables StaticGraph to act as a base class allowing us to implement more types of static graph classes such as CSRGraph in the future

@nithinmanoj10 nithinmanoj10 added the new feature Adding a new feature label Jan 16, 2024
@nithinmanoj10 nithinmanoj10 linked a pull request Jan 29, 2024 that will close this issue
@nithinmanoj10 nithinmanoj10 removed this from the 🎁 STGraph 1.1.0 Release milestone Feb 3, 2024
@nithinmanoj10 nithinmanoj10 added future-release Tasks that will be taken up for a future release and removed new feature Adding a new feature labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future-release Tasks that will be taken up for a future release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants