Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The **Authentication active?** option is ignored when not using the proxy #3

Open
pierre-josselin opened this issue Mar 28, 2024 · 2 comments

Comments

@pierre-josselin
Copy link

Hi,

I noticed that the Authentication active? option is ignored when not using the proxy.

image

Yet when Grafana attempts to access the data, it connect directly to the context broker without first requesting an access token, which generates the following error:

image

It works correctly when using the proxy mode.

This isn't necessarily a problem and seems logical from a security perspective, but perhaps it would be better to make it impossible to configure authentication if direct mode is selected?

@cnoelle
Copy link
Contributor

cnoelle commented Mar 28, 2024

Yes, it only works in proxy mode, and yes, for direct mode it should not be possible to activate authentication in the config editor.

The plugin uses the built-in Grafana OAuth capability described here: https://grafana.com/developers/plugin-tools/create-a-plugin/extend-a-plugin/add-authentication-for-data-source-plugins#add-an-oauth-20-proxy-route-to-your-plugin. It is not available in direct mode.

@pierre-josselin
Copy link
Author

Thank you for the details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants