-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redeploy breaks when a link is present #142
Comments
I definitely see the problem here. In comparison to #143, I can think of a few possible implementations that might suit us as well. Maybe inside docker_container redeploy:
Although having a separate remove_container method isn't too bad either, since we really don't need to remove the service files on redeploy. I'd just want to keep it DRY so remove also called remove_container. We could also implement a docker_link LWRP for specifically handling links since its nuanced in comparison to behavior surrounding containers themselves, then we would remove the link flag from docker_container's remove. Aside with this approach: maybe Docker should also have the ability to add links to running containers, which doesn't currently exist and would have to be submitted? Thoughts? |
Speaking of the possibility of a docker_link LWRP, I can also think of situations where we'd also want a docker_volume LWRP as well, for the similar reasons. That said, we could support actions such as remove_link and remove_volumes on docker_container too. Confusing yet? :) |
Hahaha maybe this would be a good spot to start using the docker api?
|
Haha maybe so but only if we have feature parity across the board. |
I believe this commit will close this issue: e298547 Took your approach of a separate remove_container method as well as splitting out new remove_link and remove_volume actions. I'll release it in 0.35.0. |
To reproduce:
I think this is caused by the link flag being set improperly on the docker rm... It seems to want a bool not a string.
The text was updated successfully, but these errors were encountered: