-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon linux #144
Amazon linux #144
Conversation
cheesefactory
commented
May 2, 2014
- Adds support for Amazon Linux
* 'amazon' included in array for RHEL types when determining init and install type
So I took a look at your code and it looks good. I'm currently working on writing some tests for it but I did notice that when trying to pull down the docker-test-image, docker on amazon threw an error about our storage driver, specifically:
The issue is that the docker-test-image was created with AUFS while Docker running on Amazon Linux is using devicemapper. There are two/three potential solutions: 1) ignore the problem and pull down an image built with devicemapper; 2) install aufs as part of the recipe or 3) print a computability message in the Chef Log warning about potential rootfs incompatibilities. My personal preference is a combination of 1 and 3 and the one I am going with in my solution since having a way to detect whether or not we are running on aufs or devicemapper automatically would be a huge win. |
That should /not/ be a problem. Docker containers are intended to be agnostic of what driver they're used with. They aren't even stickied to what docker version created them. |
@jayofdoom That would be the sane thing. Regardless, there is still an issue with the installation and it has to do with the storage driver. If its not AUFS vs devicemapper then its something else. :/
|
I think I found the issue. On Amazon we should not be using the 'docker-io' package from yum-EPEL. If we use the package that comes from AWS' repo it works. Testing now. |
Doh! Thanks @tduffield |
@tduffield How are you testing the addition of Amazon Linux? I wanted to add an entry to kitchen.yml but I couldn't find a Vagrant box for the OS.. |
@cheesefactory I'm using the vagrant-ec2 plugin and launching boxes in EC2. |
@cheesefactory sorry, i meant kitchen-ec2 |
Please let me know if either of you can get the non-EPEL installation worked out so we can merge in the Amazon support. I'll hold off from doing anything here until then. Thanks! |
I'll go ahead and merge to finish this up for release in 0.35.0. |
This really shouldn't have been merged - the EPEL version doesn't work on Amazon Linux :/ |
Tend to agree.... Also - in the most recent release of Amazon Linux I believe docker will be installed by default (to support their Beanstalk Docker stuff). I'm not sure what sort of implication (if any) that has on managing docker installs via this cookbook. Thoughts? Also, sorry I've been a bit absent in this PR.. |
There shouldn't be an implication since Chef will only install Docker if it On Wed, May 7, 2014 at 9:39 AM, David John notifications@github.com wrote:
|
Sorry for the confusion. I merged this in and fixed it locally. I just need Brian Flad
|