Major Fixes #147
Major Fixes #147
Conversation
…recipe preventing mac_os_x from triggering; added mac_os_x to package array in attributes
…ages and prevent new users from getting confused as to why their docker install isn't working
|
This is huge! I'll take a look at this later today and help get it merged. |
| * Changed provisioner from chef-solo to chef-zero | ||
| * Removed Ubuntu 12.10 because it is not supported by Docker and the Kernel is bad and fails all the tests. | ||
| * Removed tests for the source recipe. The dotcloud/docker repo actually doesn’t build any Go deliverables. | ||
| * I think that the source recipe needs to be completely refactored. |
There was a problem hiding this comment.
Most likely. I haven't really touched the source recipe since Docker 0.1 came out.
|
Okay I've quickly gone though everything and its awesome. For the few adjustments I've mentioned, do you want me to handle the rebase and changes? Thanks again! |
|
If you could handle those that would be great. part of the reason that I submitted this pass PR was because I got distracted by something else and wanted to make sure you got them. |
|
Absolutely, just didn't want to duplicate effort. I really appreciate this and should be able to get it in today or tomorrow. |
|
waiting for this to be merged before I get my hands dirty in dockerland =) |
Conflicts: .kitchen.yml CHANGELOG.md attributes/default.rb recipes/binary.rb
|
After a long personal hiatus, I'm back to working on this. Sorry everyone! |
docker::dep_checkthat will take an action if certain dependencies are not met.node[docker][alert_on_error_action] = :fatalwill kill the chef run and print the error message.node[docker][alert_on_error_action] = :warnwill print the error message but continue with the chef run. There is no guarantee that it will succeed though.