Chefspec 4.1 deprecation warnings #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was actually in the process of converting the syntax but thanks for fixing the expect syntax. If its okay with you i'll probably just cherrypick your first commit. |
|
Sure @tduffield it is okay with me. Let's make these tests work again without deprecation spam. |
|
Manually merged into 0.35-stable branch. |
|
Now that chef-boneyard/windows#132 has been merged, the chef specs (on my local branch) run without warnings. Make sure to berks update to windows 1.34.8 at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently released chefspec 4.1 deprecates syntax that is used in this cookbook's spec and in some of its indirect dependencies (see chef-boneyard/windows#132). As a consequence running specs with chefspec 4.1 results in hundred of lines of deprecation warnings.
This PR does:
Once all dependencies are updated, I will add a final changeset to this PR to make the specs fully compatible with chefspec 4.1.