feature(upgrade): Add ability to set package action #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jayofdoom
commented
Nov 9, 2013
jayofdoom
commented
- Set node['docker']['package']['action'] to the string representation of the action you wanna take
|
Can we change the attribute to |
|
@bflad Reimplemented in the method you suggested. Please re-review. Thanks, Jay |
|
I will fix that build failure and push a new commit up to fix |
- Allows someone to override default action of :install to instead :upgrade
|
This is working in my environment. Awaiting merge so I can start back using your upstream version :) |
|
LGTM - merging. Thanks for the enhancement. |
bflad
added a commit
that referenced
this pull request
Nov 18, 2013
feature(upgrade): Add ability to set package action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.