Use kernel release for package name on saucy and newer #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jayofdoom
commented
Dec 19, 2013
jayofdoom
commented
- Use output of uname -r directly to determine proper kernel naming on saucy and newer
- We can't do this on precise (or possibly on other older versions of ubuntu) because some of their kernels return the type in the release (i.e. 3.4.5-generic instead of 3.4.5).
- Optionally, allow a cookbook user to pick the older method of finding a kernel, in case the new way breaks compatibilty for them
- Also for new method, use ohai's provided kernel release rather than shelling out to uname
|
New code path had same problem I noted in #33 -- I was no longer checking to see if the package existed before attempting to install it. This should fix it. |
|
@bflad @trintronix This should fix the issues presented in the other PR and preserve backwards compatibility. |
|
Awesome! LGTM. Getting this in there now. |
bflad
added a commit
that referenced
this pull request
Jan 2, 2014
Use kernel release for package name on saucy and newer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.