Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image action pull_if_missing and chg pull to match cli #55

Merged
merged 1 commit into from Feb 4, 2014
Merged

Add image action pull_if_missing and chg pull to match cli #55

merged 1 commit into from Feb 4, 2014

Conversation

jhulten
Copy link

@jhulten jhulten commented Feb 3, 2014

  • Add the pull_if_missing action to the image LWRP with the current functionality
  • Modify the existing pull action to check the hash of the image before and after to determine if the resource updated (and notifications should be triggered)
  • Add docker_inspect method to the helpers library

Addresses #54

@bflad
Copy link
Contributor

bflad commented Feb 3, 2014

Well, I'll give it an hour or two for other comments, but this looks good to me. Glad it was easy to implement with the hashing! I also agree with updating default LWRP behavior to match CLI behavior (leaving pull_if_missing as a custom action).

@jayofdoom
Copy link
Contributor

+1 but I would request since this is an API change it be released only in a major release

@jhulten
Copy link
Author

jhulten commented Feb 3, 2014

Cookbook is still 0.x.y. No sustained contract is implied.

@jayofdoom
Copy link
Contributor

@jhulten by "major" release, I meant more the middle number, since that's all that's generally ever been incremented.

And while I buy the idea there's not an API contract (hell, even docker is 0.x), it's nice to make the versions matter :)

@bflad
Copy link
Contributor

bflad commented Feb 3, 2014

I'll release this as 0.28.0 when I merge it shortly. I'll only increment to 1.0 when Docker does (most likely).

@bflad
Copy link
Contributor

bflad commented Feb 4, 2014

Merging now and will release after fixing up Rubocop and some additional testing.

bflad added a commit that referenced this pull request Feb 4, 2014
Add image action pull_if_missing and chg pull to match cli
@bflad bflad merged commit 10cfa73 into sous-chefs:master Feb 4, 2014
@jhulten jhulten deleted the issue54 branch February 20, 2014 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants