Return code validation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 6, 2014 15:41
Before issuing any commands that talk to the local docker daemon, make sure it is running (since its service starts in the background).
Move docker_cmd and execute_cmd into the helper mixin to remove some repeated code.
Update all call sites to use the failing version of docker_cmd.
`docker rmi` defaults to `latest` if no tag is specified. But if you have a tagged image, there might not be a latest, in which case you must qualify the image with a tag name.
|
This is great. LGTM |
| docker_cmd("rmi #{new_resource.image_name}") | ||
| image_name = new_resource.image_name | ||
| image_name = "#{image_name}:#{new_resource.tag}" if new_resource.tag | ||
| docker_cmd!("rmi #{image_name}") |
|
This is super awesome! Thanks for the enhancements and bugfixes. Will merge and release in 0.30.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address #49 and #52