-
Notifications
You must be signed in to change notification settings - Fork 25
/
R019.go
62 lines (48 loc) · 1.53 KB
/
R019.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
package R019
import (
"flag"
"go/ast"
"golang.org/x/tools/go/analysis"
"github.com/bflad/tfproviderlint/passes/commentignore"
"github.com/bflad/tfproviderlint/passes/helper/schema/resourcedatahaschangescallexpr"
)
const Doc = `check for (*schema.ResourceData).HasChanges() calls with many arguments
The R019 analyzer reports when there are a large number of arguments being
passed to (*schema.ResourceData).HasChanges(), which it may be preferable to
use (*schema.ResourceData).HasChangesExcept() instead.
Optional parameters:
-threshold=5 Number of arguments for reporting
`
const analyzerName = "R019"
var (
threshold int
)
var Analyzer = &analysis.Analyzer{
Name: analyzerName,
Doc: Doc,
Flags: parseFlags(),
Requires: []*analysis.Analyzer{
commentignore.Analyzer,
resourcedatahaschangescallexpr.Analyzer,
},
Run: run,
}
func parseFlags() flag.FlagSet {
var flags = flag.NewFlagSet(analyzerName, flag.ExitOnError)
flags.IntVar(&threshold, "threshold", 5, "Number of arguments for reporting")
return *flags
}
func run(pass *analysis.Pass) (interface{}, error) {
ignorer := pass.ResultOf[commentignore.Analyzer].(*commentignore.Ignorer)
callExprs := pass.ResultOf[resourcedatahaschangescallexpr.Analyzer].([]*ast.CallExpr)
for _, callExpr := range callExprs {
if ignorer.ShouldIgnore(analyzerName, callExpr) {
continue
}
if len(callExpr.Args) < threshold {
continue
}
pass.Reportf(callExpr.Pos(), "%s: d.HasChanges() has many arguments, consider d.HasChangesExcept()", analyzerName)
}
return nil, nil
}