Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragScrollModule fails to load with angular cli 1.5.0 #69

Closed
marayfirth opened this issue Nov 2, 2017 · 7 comments
Closed

DragScrollModule fails to load with angular cli 1.5.0 #69

marayfirth opened this issue Nov 2, 2017 · 7 comments

Comments

@marayfirth
Copy link

After upgrading to Angular 5.0 and Angular CLI 1.5, I get an error with ng serve.

ERROR in ./node_modules/angular2-drag-scroll/src/angular2-drag-scroll.ts
Module build failed: Error: C:\Dev\OrderingSystem\client\node_modules\angular2-drag-scroll\src\angular2-drag-scroll.ts is not part of the compilation output. Please check the other error messages for details.
    at AngularCompilerPlugin.getCompiledFile (C:\Dev\OrderingSystem\client\node_modules\@ngtools\webpack\src\angular_compiler_plugin.js:629:23)
    at plugin.done.then (C:\Dev\OrderingSystem\client\node_modules\@ngtools\webpack\src\loader.js:467:39)
    at process._tickCallback (internal/process/next_tick.js:109:7)
 @ ./node_modules/angular2-drag-scroll/index.js 3:29-66
 @ ./src/app/venue/venue.module.ts
 @ ./src/app/app.module.ts
 @ ./src/main.ts
 @ multi webpack-dev-server/client?http://0.0.0.0:0 ./src/main.ts

webpack: Failed to compile.

Version of angular2-drag-scroll: 1.4.4

Might be related to this one : angular/angular-cli#8263
I reproduce when not setting aot though.

@MonasteryJohn
Copy link

Seems to be related to angular/angular-cli#8284 due to ts files being in the dist. Many people are having this issue with lots of packages after the upgrade to angular5.

I've been able to work around this for now by modifying my src/tsconfig.app.json to have the files the compiler is complaining about the in the "includes" array. If you check the link they recommend against this, but it should work until these libraries are updated.

@akkumar akkumar mentioned this issue Nov 8, 2017
Merged
@bfwg
Copy link
Owner

bfwg commented Nov 10, 2017

1.4.5 is out with the fix. Thanks guys!

@akkumar
Copy link
Contributor

akkumar commented Nov 14, 2017

@marayfirth @MonasteryJohn - I have put in a fix here at #75 .

It would involve pointing angular2-drag-scroll to the following:

"angular2-drag-scroll": "git@github.com:akkumar/angular2-drag-scroll.git#d9e880e3d74988253846e5caec6625e0d78351c7"

Can you help check if that fix works and report issues if any ? Thanks in advance

@bfwg bfwg reopened this Nov 14, 2017
@marayfirth
Copy link
Author

@akkumar it seems ok on my side with this version.

@akkumar
Copy link
Contributor

akkumar commented Nov 14, 2017

@marayfirth - Thanks for confirming. Also to help - can you add your npm version and node version, in which this works ?

@bfwg - May be - we can just cut a release 1.5.0 with the PR #75 and debug it later if needed :)

@marayfirth
Copy link
Author

Working with

  • node 6.11.0
  • npm 5.5.1

@bfwg
Copy link
Owner

bfwg commented Nov 14, 2017

1.5.0 is out with #75 , thanks guys!

@bfwg bfwg closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants