Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch custom webpack build step to ember-auto-import #159

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

jasonmit
Copy link
Contributor

@jasonmit jasonmit commented Jul 26, 2018

fixes #145, #152

Side note, would much appreciate a beta or an rc tag once this is merged. Will enable me to get off my fork that hacked together engine support.

@jasonmit jasonmit changed the title Switch custom webpack build step to ember-auto-import feat(hold): Switch custom webpack build step to ember-auto-import Jul 26, 2018
@jasonmit jasonmit force-pushed the u/jasonmit/e-auto-import branch 2 times, most recently from 94fda79 to 50a1a7b Compare July 28, 2018 22:08
@jasonmit jasonmit changed the title feat(hold): Switch custom webpack build step to ember-auto-import feat: Switch custom webpack build step to ember-auto-import Jul 28, 2018
@jasonmit
Copy link
Contributor Author

@dfreeman & @bgentry I resolved the bundling issues with graphql-js

Let me know if there is anything else needed to get this merged.

Thanks again!

autoImport: {
webpack: {
module: {
rules: [
Copy link
Contributor Author

@jasonmit jasonmit Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only needed for 0.13.1 & 0.13.2. This issue does not exist in <= 0.13.0 and >= 14.0.0-rc.1. Verified configuration is safe for all versions of graphql-js.

@bgentry
Copy link
Member

bgentry commented Jul 30, 2018

Thanks @jasonmit, this looks great! Since it is a breaking change, prior to merging and releasing it I want to finish up #156 to deprecate the old mixin import paths. Then we can release a v2 beta with this new packaging setup and the old mixin imports removed entirely.

@jasonmit
Copy link
Contributor Author

@bgentry friendly ping. Let me know if there is anything I can do.

@bgentry
Copy link
Member

bgentry commented Aug 23, 2018

Thanks @jasonmit! The blocker remains that I want to deprecate the old import paths in a release before the major upgrade. So if you’re able to help with that it would be 🙏🏻

I guess another option would be to make a new branch for 1.x, then merge this and release a 2.0 beta that doesn’t yet include the deprecations. So I could do that pretty soon if nobody is able to help with #156

@jasonmit
Copy link
Contributor Author

@bgentry #167 thanks!

@josemarluedke
Copy link
Member

Any plans on getting this merged/released soon?

@bgentry
Copy link
Member

bgentry commented Sep 14, 2018

@josemarluedke yep, coming today, sorry for the long delay!

@bgentry bgentry merged commit a721d67 into ember-graphql:master Sep 14, 2018
@bgentry
Copy link
Member

bgentry commented Sep 14, 2018

One thing that appears to have been lost with this PR is that the readme no longer explains how to import additional packages. Since folks are likely coming from 1.x where this is a bundled feature, maybe we should explain what they get out-of-the-box and show an example or at least link to ember-auto-import for how to get additional Apollo-related packages loaded?

Can anybody PR that small doc fix today? Then I'll publish a v2.x beta.

Thanks so much for this PR @jasonmit 👏 sorry for how long this took to ship 😞

@jasonmit jasonmit deleted the u/jasonmit/e-auto-import branch September 17, 2018 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ember-auto-import for packaging?
3 participants