Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to C function calceph_gettimespan (get ephemeris time span) added #3

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

mkretlow
Copy link
Contributor

Hello,

while I was evaluating your CALCEPH Julia package (thanks for sharing!) I missed the possibility to get the time span of the ephemeris (I was using classical DExxx binary files which I used before with my Fortran programs). So I added the corresponding call. Maybe you want to merge it into your source.

Cheers, Mike

@codecov-io
Copy link

codecov-io commented Nov 23, 2018

Codecov Report

Merging #3 into master will decrease coverage by 36.28%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
- Coverage      86%   49.71%   -36.29%     
===========================================
  Files           9       10        +1     
  Lines         100      173       +73     
===========================================
  Hits           86       86               
- Misses         14       87       +73
Impacted Files Coverage Δ
src/CALCEPH.jl 100% <ø> (ø) ⬆️
src/timespan.jl 0% <0%> (ø)
src/fivePointStencil.jl 39.13% <0%> (-60.87%) ⬇️
src/introspection.jl 48.38% <0%> (-51.62%) ⬇️
src/orient.jl 18.18% <0%> (-48.49%) ⬇️
src/compute.jl 37.5% <0%> (-48.22%) ⬇️
src/rotAngMom.jl 36.36% <0%> (-43.64%) ⬇️
src/constants.jl 83.33% <0%> (-16.67%) ⬇️
src/bodyId.jl 44.44% <0%> (-12.7%) ⬇️
src/ephem.jl 77.27% <0%> (-12.21%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9583447...ecab2e5. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 23, 2018

Pull Request Test Coverage Report for Build 58

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 66 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-36.3%) to 49.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/timespan.jl 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/ephem.jl 3 77.27%
src/constants.jl 4 83.33%
src/bodyId.jl 6 44.44%
src/rotAngMom.jl 6 36.36%
src/orient.jl 8 18.18%
src/compute.jl 9 37.5%
src/fivePointStencil.jl 14 39.13%
src/introspection.jl 16 48.39%
Totals Coverage Status
Change from base Build 57: -36.3%
Covered Lines: 86
Relevant Lines: 173

💛 - Coveralls

@bgodard bgodard merged commit f8ea1e5 into JuliaAstro:master Dec 7, 2018
@bgodard
Copy link
Member

bgodard commented Dec 7, 2018

Thank you for this feature. It is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants