Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling in trunk #28

Closed
lainz opened this issue Jan 19, 2019 · 20 comments
Closed

Compiling in trunk #28

lainz opened this issue Jan 19, 2019 · 20 comments

Comments

@lainz
Copy link
Member

lainz commented Jan 19, 2019

umultiimage.pas(74,30) Error: Only static methods and static variables can be referenced through an object type

@circular17
Copy link
Collaborator

Fixed on dev-vectorial branch, I will merge it soon with dev-bgrabitmap
(to solve it locally, simply add static keyword after the called method definition)

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

Hi, I switched to dev-vectorial and still not working.
I added static to the end of the method TFMultiImage.ShowAndChoose and says that static is not allowed here.

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

Sorry I found the problem was I switched only to dev-vectorial of lazpaint and not to dev-vectorial of bgrabitmap.

@circular17
Copy link
Collaborator

circular17 commented Jan 20, 2019

Hmmm I am surprised I believe there is nothing in dev-vectorial of bgrabitmap. In fact I did not intend to create this branch. I created it from LazPaint and from some reason it was added in bgrabitmap too.

And the method TFMultiImage.ShowAndChoose is not meant to be static.

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

Still not compiling but for another reasons not static, maybe there are files missing?

What combination of branches should I use to test?

@circular17
Copy link
Collaborator

What error do you get?

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

Using dev-vectorial in both sources I get:
ustatetype.pas(1058,19) Error: Identifier idents no member "SaveOriginalToStream"
ustatetype.pas(1075,72) Error: Wrong number of parameters specified for call to "AddOriginalFromStream"
bgralayers.pas(1262,29) Error: Found declaration: AddOriginalFromStream(TStream):LongInt;
ustatetype.pas(1084,65) Error: Identifier idents no member "OriginalGuid"
ustatetype.pas(1102,72) Error: Wrong number of parameters specified for call to "AddOriginalFromStream"
bgralayers.pas(1262,29) Error: Found declaration: AddOriginalFromStream(TStream):LongInt;
ustatetype.pas(1105,64) Error: Identifier idents no member "OriginalGuid"
ustatetype.pas(1112,64) Error: Identifier idents no member "OriginalGuid"

@circular17
Copy link
Collaborator

Hmm try setting branch to dev-bgrabitmap and pull the last changes

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

If I switch back to dev branch I get the original problem of static. Even pulling all new stuff.

@circular17
Copy link
Collaborator

Ok. What error do you get ?

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

umultiimage.pas(74,30) Error: Only static methods and static variables can be referenced through an object type

@circular17
Copy link
Collaborator

Ok. When you CTRL-Click to get the definition of Empty, what do you have?

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

Oh I see, I fixed it adding static into 2 class functions.
class function Empty: TImageEntry; static;
class function NewFrameIndex: integer; static;

@circular17
Copy link
Collaborator

Those are already on the latest dev-vectorial branch of LazPaint.

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

Ok thanks for adding it. Seems that I had missing the 2 latest commits.

@circular17
Copy link
Collaborator

Ok. Sorry for the confusion, I don't know why there is a dev-vectorial on bgrabitmap.

@lainz
Copy link
Member Author

lainz commented Jan 20, 2019

Ok, no problem. You can easily delete it from the web gui. But check if there is nothing inside that can be lost.

@circular17
Copy link
Collaborator

Yeah I don't want to loose my changes. Maybe I will wait after I merge LazPaint branch to be sure.

@circular17
Copy link
Collaborator

So in this dev-vectorial, I am making LazPaint compatible with the vector layers. Not adding yet the vectorial tools. Just that if you load something that contains an original, it will preserve it. For example something from vectoredit or the file generated by test/layeroriginal.

@lainz
Copy link
Member Author

lainz commented Jan 21, 2019

Cool =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants