Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'$request->getContent()' may need an additional type check #6

Open
justinhartman opened this issue Nov 15, 2019 · 0 comments
Open

'$request->getContent()' may need an additional type check #6

justinhartman opened this issue Nov 15, 2019 · 0 comments

Comments

@justinhartman
Copy link

justinhartman commented Nov 15, 2019 •
edited
Loading

PR #4 introduces a new issue around type checking as outlined on Scrutinizer. Details as follows.

Scrutinizer

  1. IssueId: 41884235

Message:

It seems like $request->getContent() can also be of type resource; however, parameter $data of hash_hmac() does only seem to accept string, maybe add an additional type check?

File details

Filename: src/Http/Controllers/WebhookController.php
LineNumber: 42
@justinhartman justinhartman changed the title $request->getContent() may need an additional type check '$request->getContent()' may need an additional type check Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinhartman