Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API Property - neighbors #46

Closed
sthiepaan opened this issue Oct 3, 2020 · 3 comments · Fixed by #66
Closed

Add new API Property - neighbors #46

sthiepaan opened this issue Oct 3, 2020 · 3 comments · Fixed by #66
Assignees

Comments

@sthiepaan
Copy link
Collaborator

After short introduction in #32 we decided to extend this package with neighbors Property:

  • neighbors Property is a string[] (list of strings)
  • Each value in that property is a value taken from iso.alpha_2 of a country
  • The values should be ordered alphabetically
  • For the project needs all new properties will be lowercase.

After adding new property, each Country {Object} should contain:

{
  "country": "poland",
  "capital": "warsaw",
  "currency": "zloty",
  "native_language": ["polish"],
  "famous_for": "pierogi and potatoes",
  "phone_code": "+48",
  "flag": "https://flagpedia.net/data/flags/h80/pl.png",
  "drive_direction": "right",
  "iso": {
    "numeric": "616",
    "alpha_2": "pl",
    "alpha_3": "pol"
  },
  // NEW DATA
  "neighbors": ["by", "cz", "de", "lt", "ru", "sk", "ua"]
},

Additionally there will be new method to use that data:

  • getCountryNeighbors(countryName)

NOTE: This feature is dependant on #42 so it has to be merged before preparing this

@sthiepaan
Copy link
Collaborator Author

@bhatvikrant since this is connected with #42 and I am working on this let me take care of that one 😉

@bhatvikrant
Copy link
Owner

Okay @sthiepaan I will assign this one to you too.

@sthiepaan
Copy link
Collaborator Author

@bhatvikrant when will you have time to do the code review for #42 Pull Request? As I mentioned earlier, this one is dependent on it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants