Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API Property - is_landlocked #47

Closed
sthiepaan opened this issue Oct 3, 2020 · 5 comments · Fixed by #56 or #61
Closed

Add new API Property - is_landlocked #47

sthiepaan opened this issue Oct 3, 2020 · 5 comments · Fixed by #56 or #61
Assignees

Comments

@sthiepaan
Copy link
Collaborator

After short introduction in #32 we decided to extend this package with is_landlocked Property:

  • is_landlocked Property is a Boolean

After adding new property, each Country {Object} should contain:

{
  "country": "poland",
  "capital": "warsaw",
  "currency": "zloty",
  "native_language": ["polish"],
  "famous_for": "pierogi and potatoes",
  "phone_code": "+48",
  "flag": "https://flagpedia.net/data/flags/h80/pl.png",
  "drive_direction": "right",
  // NEW DATA
  "is_landlocked": false
},

Additionally there will be new method to use that data:

  • getCountriesByLandlock(isLandLocked)
@jav7zaid
Copy link
Contributor

jav7zaid commented Oct 3, 2020

@bhatvikrant can you assign this to me? I think this would be good first issue and contribution ? Thanks 👍

@bhatvikrant
Copy link
Owner

@jav7zaid Sure thing! I have assigned this issue to you.
All the best!
Also, please don't forget to mention your source of data in the PR.😀

@jav7zaid
Copy link
Contributor

jav7zaid commented Oct 4, 2020

@bhatvikrant thanks! 😄

@sthiepaan sthiepaan linked a pull request Oct 18, 2020 that will close this issue
@jav7zaid
Copy link
Contributor

@sthiepaan can you please open this PR , i need to fix the existing test cases that broke.

@sthiepaan
Copy link
Collaborator Author

sthiepaan commented Oct 24, 2020

Sure 👍 Can you make a new Pull Request with fix for that?
Nevermind, I will fix it. Thank you @jav7zaid for all your efforts!

@sthiepaan sthiepaan reopened this Oct 24, 2020
@sthiepaan sthiepaan linked a pull request Oct 24, 2020 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants