Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API Property - minimum_driving_age #49

Closed
sthiepaan opened this issue Oct 3, 2020 · 2 comments
Closed

Add new API Property - minimum_driving_age #49

sthiepaan opened this issue Oct 3, 2020 · 2 comments

Comments

@sthiepaan
Copy link
Collaborator

After short introduction in #32 we decided to extend this package with minimum_driving_age Property:

  • minimum_driving_age Property is a Number that represents minimum age to drive a car

After adding new property, each Country {Object} should contain:

{
  "country": "poland",
  "capital": "warsaw",
  "currency": "zloty",
  "native_language": ["polish"],
  "famous_for": "pierogi and potatoes",
  "phone_code": "+48",
  "flag": "https://flagpedia.net/data/flags/h80/pl.png",
  "drive_direction": "right",
  // NEW DATA
  "minimum_driving_age": 18
},

Additionally there will be new method to use that data:

  • getCountriesByMinimumDrivingAge(minimumAge, isExact)
@bhatvikrant
Copy link
Owner

@sthiepaan I am not sure about this property. I feel it's not that common/useful. (Please feel free to contest me by all means)

Let's keep this low priority for now.

@sthiepaan
Copy link
Collaborator Author

It came to my mind because we have drive_direction Property 😛

I checked what are the values for countries and it looks like there are not much "unexpected" values that we would like to share. Mostly it is a range between 15 and 20 where most of the countries have 18 as a minimum driving age.

So for now I will close this ticket and we can reopen it if we are back to this topic.
Thanks for an input @bhatvikrant ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants