Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't pass arguments to watch-and-reload #21

Closed
ivan opened this issue May 23, 2014 · 1 comment
Closed

Can't pass arguments to watch-and-reload #21

ivan opened this issue May 23, 2014 · 1 comment

Comments

@ivan
Copy link
Contributor

ivan commented May 23, 2014

watch-and-reload takes :key value varargs and watch-and-reload-with-opts tries to merge a map with a list of those varargs. Essentially, it's doing something like ((fn [& opts] (merge {} opts)) :a 1). This doesn't work in ClojureScript, though (or Clojure, for that matter.)

To reproduce this, try (fw/watch-and-reload :jsload-callback (fn [])); ClojureScript 2202 will throw an error with is not ISeqable and ClojureScript 2227 will throw something with conj on a map takes map entries or seqables of map entries.

This regressed in 6b313e4

@bhauman
Copy link
Owner

bhauman commented May 23, 2014

Thanks Ivan. That's a good one. I just committed a fix
4d06453

It's probably time for me to get a set of tests in place.

I am going to cut a new snapshot today or tomorrow.

I really appreciate your participation man, thanks again.

@bhauman bhauman closed this as completed May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants