When expound can't print error (due to conformers), print vanilla spec error

[bhb]

No description provided.

[bhb]

Related: #102

[bhb]

Workaround:

(require '[expound.alpha :as expound])

(defn safe-printer [explain-data]
  (let [exp (expound/custom-printer {})]
    (try
      (exp explain-data)
      (catch Exception e e
             (s/explain-printer explain-data)))))

(set! s/*explain-out* safe-printer)

(s/def ::sorted-pair (s/and (s/cat :x int? :y int?) #(< (-> % :x) (-> % :y))))

;; Usually use expound
(s/explain int? "a")
;;-- Spec failed --------------------
;;
;;  "a"
;;
;;should satisfy
;;
;;  int?
;;
;;-------------------------
;;Detected 1 error

;; If there is an issue, fallback on s/explain-printer
(s/explain ::sorted-pair [0 0])
;; val: {:x 0, :y 0} fails spec: :expound.alpha/sorted-pair predicate: (< (-> % :x) (-> % :y))

[arichiardi]

I have run into this and thanks for the workaround!

[bhb]

@arichiardi @borkdude I've got a fix for this issue in 0.7.2-SNAPSHOT. If you have time to try it out, please let me know what you think!

[arichiardi]

First feedback, with shadow-cljs I receive these warnings:

------ WARNING #1 --------------------------------------------------------------
 File: expound/problems.cljc:110:47
--------------------------------------------------------------------------------
 107 |                         :clj java.lang.Exception) _e
 108 |                 nil)
 109 |               (catch #?(:cljs :default
 110 |                         :clj java.lang.Error) _e
-----------------------------------------------------^--------------------------
 Use of undeclared Var expound.problems/_e
--------------------------------------------------------------------------------
 111 |                 nil))
 112 | 
 113 |         new-in (cond in1
 114 |                      in1
--------------------------------------------------------------------------------

[bhb]

Good catch! I've added a new check for warnings to the CI script and fixed this warning. I've pushed a new version of 0.7.2-SNAPSHOT with the fix.

[borkdude]

@bhb Is this also available in master?

I've tried http://bit.ly/speculative-repl with

(stest/instrument `subs)
(try
  ;; insert your call here
  (subs "foo" 5)
  (catch :default e
    (println (.-message e))
    (throw e)))

and I'm seeing:

Cannot convert path. This can be caused by using conformers to transform values, which is not supported in Expound

[bhb]

This is currently only on the “next” branch. I’m hoping to get a release out this month, which will move this to master.

[bhb]

Fixed in 0.7.2-SNAPSHOT (to be released soon)