This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Dir add hyperlink #1052
Open
Dir add hyperlink #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhilburn
reviewed
Nov 5, 2018
powerlevel9k.zsh-theme
Outdated
| @@ -22,7 +22,7 @@ | |||
| ################################################################ | |||
|
|
|||
| # Define the version number. This will make it easier to support as users can report this with tickets. | |||
| readonly P9K_VERSION="0.7.0" | |||
| declare -g P9K_VERSION="0.7.0" | |||
There was a problem hiding this comment.
Does this change need to be made in this PR for the functionality to work?
|
Wow, @onaforeignshore! Nice work getting this implemented so quickly onto |
dritter
reviewed
Nov 10, 2018
There was a problem hiding this comment.
Code looks good to me. My only concerns are:
- does this get correctly counted when using the zero pattern (
local zero='%([BSUbfksu]|([FB]|){*})')? This is used intruncate_with_package_namestrategy, and probably in the newline segment improvement.. - does this work in all terminals?
Second thought: maybe this is interesting for other agents as well. I am thinking of a segment that reads the to url out of git or a a package.json..
|
In non-supported terminals this should just not show up. General url support would be great if it'll work. |
romkatv
added a commit
to romkatv/powerlevel10k
that referenced
this pull request
Jun 20, 2019
This is a port of Powerlevel9k/powerlevel9k#1052.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for hyperlinking of folders to terminals that support it.
This will require extensive testing and feedback, so please feel free to test it :)
Implements #890 on the new code base (as requested in #857)