Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bluebird dependency if native promises are available #1

Closed
neuhaus opened this issue Jan 11, 2018 · 4 comments
Closed

remove bluebird dependency if native promises are available #1

neuhaus opened this issue Jan 11, 2018 · 4 comments
Assignees
@bhoriuchi
Labels
enhancement

Comments

@neuhaus
Copy link

neuhaus commented Jan 11, 2018

I don't need bluebird, I have native promises...
@bhoriuchi bhoriuchi self-assigned this Jan 11, 2018
@bhoriuchi
Copy link
Owner

bhoriuchi commented Jan 11, 2018 •
edited
Loading

I'll work on this soon. You are correct, there is no need to use bluebird since native promises fulfill all the requirements.

@bhoriuchi
Copy link
Owner

The code base for this project has been modernized and additional methods have been added. version 1.0.0 has been published to npm. See updated readme for api and release section for breaking changes.

@neuhaus
Copy link
Author

neuhaus commented Jan 11, 2018

Great, thanks

@bhoriuchi
Copy link
Owner

@neuhaus i accidentally published with some dependencies that should have been added as devDependencies. I have corrected this and published v1.0.2 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhoriuchi bhoriuchi

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neuhaus @bhoriuchi