Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration #194

Closed
wants to merge 4 commits into from
Closed

Configuration #194

wants to merge 4 commits into from

Conversation

bhouston
Copy link
Owner

@bhouston bhouston commented Dec 23, 2022

This adopts the convention that nodes now have a "configuration" section that is for non-run-time parameters.

For example, Sequence node can have variable number of outputs. Now you can specify numOutputs for sequence in its configuration.

Here is the list of nodes that currently support configuration:

  • Sequence: numOutputs
  • WaitAll: numInputs
  • VariableSet: variableId
  • VariableGet: variableId
  • CustomEvent Trigger: customEventId
  • CustomEvent On Trigger: customEventId

For example this:

   {
       "type": "customEvent/trigger/0",
       "id": "1"
     },

Becomes this:

  {
       "type": "customEvent/trigger",
       "configuration": {
         "customEventId": 0
       },
       "id": "9"
     }

@bhouston
Copy link
Owner Author

This fixes #180

@bhouston
Copy link
Owner Author

This is merged on my side of things.

@bhouston bhouston closed this Dec 23, 2022
@oveddan
Copy link
Collaborator

oveddan commented Dec 23, 2022

@bhouston can you please give me a chance to review these before merging? I'd love to have the chance to provide some feedback. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants