Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle library #21

Merged
merged 3 commits into from Aug 2, 2022
Merged

Bundle library #21

merged 3 commits into from Aug 2, 2022

Conversation

beeglebug
Copy link
Collaborator

Hi, I was interested in using this library, but noticed an open issue to get it bundled and published, so thought i'd have a quick stab at a basic rollup config.

In this initial version i've only exported the files necessary to replicate the code in runner.js (GraphEvaluator, loadGraph, NodeRegistry and registerGenericNodes).

I assume there is other code which would be helpful to a user of the library, but until I can play around with it a bit more, I thought it best to raise it now and ask what else to add.

@beeglebug
Copy link
Collaborator Author

I've left this as a draft for now because it currently breaks the npm run exec command due to runner.ts not being transpiled any more. I need to think of a sensible solution to that which doesn't over complicate the build process.

@beeglebug
Copy link
Collaborator Author

ok so exec is all fixed now, i've changed Runner.ts to Runner.js and set node up in esm mode via type: module in package.json and its all good. Only thing I need a bit of input on is what else to export in index.ts I guess?

@beeglebug beeglebug marked this pull request as ready for review August 2, 2022 12:56
@bhouston
Copy link
Owner

bhouston commented Aug 2, 2022

This is amazing! I'll have a look now!

@bhouston bhouston merged commit 3b3c498 into bhouston:main Aug 2, 2022
@bhouston
Copy link
Owner

bhouston commented Aug 2, 2022

Thank you! I just added a bunch more exports and it worked great!

@bhouston
Copy link
Owner

bhouston commented Aug 3, 2022

It is now also available on npm: https://www.npmjs.com/package/behave-graph

There was already a "behavior-graph" on npm so I changed the name to "behave-graph" for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants