Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

331/ Сбор информации об окружении #359

Merged
merged 4 commits into from
May 25, 2024

Conversation

alkoleft
Copy link
Member

Описание изменений

Добавлена информация об окружении


  • Добавлены тесты
  • Изменения отражены в документации (при необходимости)

Close #331

Copy link
Contributor

github-actions bot commented May 22, 2024

SonarQube Code Analytics

Quality Gate passed

passed

Additional information

The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.

Issues

bug 0 Bugs

vulnerability 0 Vulnerabilities

code_smell 0 Code Smells

Coverage and Duplications

No data Coverage

duplication_lt_3 0.00% Duplication

//
// Возвращаемое значение:
// Строка
Функция ПредставлениеОшибки(Описание, Ошибка = Неопределено) Экспорт
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Ошибка" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort


Для Инд = 1 По СтрДлина(ВходнаяСтрока) Цикл
КодСимволаЗначения = КодСимвола(ВходнаяСтрока, Инд);
Если КодСимволаЗначения > 127 Тогда
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Создайте константу с понятным названием, присвойте ей значение "127" и используйте эту константу вместо магического числа. Why is this an issue?

CODE_SMELL Codesmell  MINOR Minor  :hourglass: 1min effort

Число = Цел(Число / Основание);
КонецЦикла;

Пока СтрДлина(Результат) < 4 Цикл
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Создайте константу с понятным названием, присвойте ей значение "4" и используйте эту константу вместо магического числа. Why is this an issue?

CODE_SMELL Codesmell  MINOR Minor  :hourglass: 1min effort

#КонецЕсли

//@skip-check use-non-recommended-method
Окружение.Вставить("ВремяЗапуска", ТекущаяДата());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Используйте "ТекущаяДатаСеанса" вместо устаревшего "ТекущаяДата" Why is this an issue?

BUG Bug  MAJOR Major  :hourglass: 5min effort

//
// Возвращаемое значение:
// Строка
Функция ПредставлениеОшибки(Описание, Ошибка = Неопределено) Экспорт
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Ошибка" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

@alkoleft alkoleft merged commit 05ea150 into develop May 25, 2024
6 of 16 checks passed
@alkoleft alkoleft deleted the feature/331 branch May 25, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] Информация об окружении
1 participant