Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image description/shadow off #268

Closed
sal0max opened this issue Jul 16, 2021 · 4 comments
Closed

Image description/shadow off #268

sal0max opened this issue Jul 16, 2021 · 4 comments

Comments

@sal0max
Copy link

sal0max commented Jul 16, 2021

Describe the bug
Image descriptions and its shadow are off by 15px, resulting in a brighter area below it.

Are you able to reproduce the bug in the demo site
Yes

To Reproduce
Steps to reproduce the behavior:

  1. Open an image with an image description on a mobile device (e. g. with Android user agent)
  2. To better see the issue, turn it into landscape orientation
  3. See the light area at the bottom, below the descripton

Code to solve this issue
The bug seems to be solvable by changing https://github.com/biati-digital/glightbox/blob/master/src/postcss/glightbox.css#L333 to bottom: 0px

Screenshots
Bildschirmfoto am 2021-07-17 um 01 36 58

Desktop:
No issue here

Smartphone:
All devices where isMobile() returns true.

@gingerchew
Copy link
Collaborator

Hey there @sal0max,

Thanks for filing this issue!

I can confirm this is happening on my iPhone 12 as well.

I'll add this as a bug and good first issue.

@clemensg
Copy link

clemensg commented Aug 17, 2021

Hi @biati-digital , Hi @Frankie-tech , first of all thank you for this awesome lightbox library.

Any ideas how to proceed regarding this issue? Setting bottom to 0px fixes the shadow issue for me.

@gingerchew
Copy link
Collaborator

@clemensg currently both I and the package maintainer are both busy at our own jobs.

You're more than welcome to make a PR yourself though.

@biati-digital
Copy link
Owner

This is fixed in the latest version 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants