Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL / TLS? #4

Closed
jeff-h opened this issue Mar 2, 2018 · 8 comments
Closed

SSL / TLS? #4

jeff-h opened this issue Mar 2, 2018 · 8 comments
Assignees

Comments

@jeff-h
Copy link
Contributor

jeff-h commented Mar 2, 2018

I'm using this to serve some stuff which my app then displays in a WKWebView. Given that Apple really want us using https, is SSL / TLS on your radar? I see you recently added it in the sockets dependency, so I'm hopeful :)

@OrkhanAlikhanov
Copy link
Member

I think adding SSL support would be easy considering that Socket.swift has it. Actually once I had thought adding it, then I decided I'll add it on demand. So since you are in need, I'll add it :) Unfortunately I am and will be really really busy these days. Probably I can do it at the next weekend. Thank you for your interest :)

@OrkhanAlikhanov OrkhanAlikhanov self-assigned this Mar 2, 2018
@jeff-h
Copy link
Contributor Author

jeff-h commented Mar 3, 2018

Wow, thanks! Love how much cleaner your code is than a certain highly-starred similar project... 🙈

@OrkhanAlikhanov
Copy link
Member

Thank you for your appreciation :)

@jeff-h
Copy link
Contributor Author

jeff-h commented Mar 14, 2018

This is awesome! Can't wait to try it out :)

@OrkhanAlikhanov
Copy link
Member

Hey! I thought I had left a comment here after closing via 1d1e268 . Seems that I hadn't. Sorry for that. You can reach me at gitter if you want to discuss something about Http.swift

@jeff-h
Copy link
Contributor Author

jeff-h commented Mar 18, 2018

Will definitely drop in and say hi on Gitter!

I found it a bit tricky to get this to build. Since I use Carthage in my project, I'm building this separately using the workspace included with this project to build the two frameworks I need (Http.swift and Sockets.swift). But running pod install on a fresh checkout of this repo just kept installing v2.1.0 of Sockets.swift, not the newly-required v2.2.0.

In the end I got it working by modifying the Podfile like so:

  # Pods for HttpSwift
  pod 'Socket.swift', :git => 'https://github.com/BiAtoms/Socket.swift.git', :branch => 'master', :tag => '2.2.0'

I'm guessing my problems are almost certainly due to my lack of understanding Cocoapods, but I mention it here in case there's some tiny config error somewhere in the project or on Cocoapods.org or something.

@OrkhanAlikhanov
Copy link
Member

The build is passing in travis ci, so I am sure about my side. Your pod repo might be out of date. Remove :git => ... stuff and try pod install --repo-update it should work. As regards the carthage, it's in my queue ;)

@jeff-h
Copy link
Contributor Author

jeff-h commented Mar 19, 2018

You're right — thanks a lot! The --repo-update was key... it builds just fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants