Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the hierarchical rule is missing #11

Closed
chrisgorgo opened this issue Dec 7, 2017 · 12 comments
Closed

Support for the hierarchical rule is missing #11

chrisgorgo opened this issue Dec 7, 2017 · 12 comments
Labels

Comments

@chrisgorgo
Copy link
Contributor

Execution failed: /opt/spm12/spm_BIDS_App.m
Error using fileread (line 22)
Could not open file /snapshot/data/sub-001/fmap/sub-001_dir-AP_epi.json. No such file or directory.
Error in fileread (line 22)
Error in parse_subject (line 326)
Error in spm_BIDS (line 122)
Error in spm (line 1210)
Error in spm_standalone (line 115)

The correct JSON file was in /snapshot/data/dir-AP_epi.json

More info at https://openneuro.org/datasets/ds001105/versions/00001?app=SPM&version=17&job=5a298a27fce2fd0001047fb6

@chrisgorgo chrisgorgo added the bug label Dec 7, 2017
@gllmflndn
Copy link
Collaborator

Thanks for the report. I fixed the bug in the SPM12 repository and will rebuild the Docker container shortly. When this is done, is there a way to restart the SPM analysis on OpenNeuro?

PS: On the OpenNeuro page, there is a link to OSF in the "References and Links":
https://osf.io/x32te/
and from there a link back to OpenNeuro:
https://openneuro.org/datasets/ds001105
but you get "You are not authorized to view this dataset" as only this one works:
https://openneuro.org/datasets/ds001105/versions/00001

@chrisgorgo
Copy link
Contributor Author

Thanks for fixing this! If you publish a new version of SPM App on GitHub I will be able to deploy it on OpenNeuro and we will be able to submit a new job.

@gllmflndn
Copy link
Collaborator

v0.0.10 has landed. Thanks!

@chrisgorgo
Copy link
Contributor Author

chrisgorgo commented Jan 9, 2018 via email

@chrisgorgo
Copy link
Contributor Author

Also - should I enable group level?

@gllmflndn
Copy link
Collaborator

I have added an example of a task at the group level (computing a mean structural image) so you can enable it.

The '--config' input argument allows to specify the path to a MATLAB script that contains a description of the task to perform at the participant or group level. See examples with the configuration files pipeline_participant.m and pipeline_group.m that are used by default, when the '--config' argument is not specified.

@chrisgorgo
Copy link
Contributor Author

chrisgorgo commented Jan 10, 2018 via email

@gllmflndn
Copy link
Collaborator

gllmflndn commented Jan 10, 2018

Yes, the way I thought about it is to have a different configuration file per level of analysis - it kind of makes sense given that analyses are always different. That said, a single user-specified configuration file could be written like this:

if strcmp(BIDS_App.level,'participant')
    % first level analysis
else
    % second level analysis
end

so this is not a limitation for OpenNeuro.
I could also add the option for '--config' to point to a folder (instead of a single file) that would contain configuration files for each level of analysis, and would be picked up appropriately automatically by the App.

@gllmflndn gllmflndn reopened this Jan 10, 2018
@chrisgorgo
Copy link
Contributor Author

chrisgorgo commented Jan 10, 2018 via email

@gllmflndn
Copy link
Collaborator

I have added a paragraph about the configuration file in the README:
https://github.com/BIDS-Apps/SPM#configuration-file

@chrisgorgo
Copy link
Contributor Author

chrisgorgo commented Jan 11, 2018 via email

@gllmflndn
Copy link
Collaborator

Will do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants