-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"PRODUCT_NAME was misdefined #7
Comments
Hi @GRyabkin, Thanks |
@bielikb I don't think it's required. The error I receive happens inside fastlane action. I duplicated my issue in their repository |
I have set Product name in build settings, here's my fastlane config:
|
Ohh, this action builds my |
Im owner of both repos, thanks for bringing your issue up. To proceed further I might need to know a little more about your setup. |
@bielikb sorry, I can't send you my setup, but I can give you answers to questions if you have them. It's cool that the action works for some basic case |
I have my Bundle name set as $(PRODUCT_NAME) maybe hardcoding this param helps but it's strange that it's not taken into account. |
Is it hard to reproduce your setup in form of a dummy project? In terms of details, let's step back.
Additionally you're welcome to adjust the functionality of the open sourced plugin, in that case, please follow the contribution guideline |
@bielikb yes, this is a production setup which has many third-party-dependencies, also I have signed NDA.
|
@bielikb also looks like |
@bielikb the error was generated by line 28 in the following file |
@bielikb I would like to contribute. Do you happen to share some guides on how to test the action without deploying to the Fastlane repository? |
@bielikb today I had more time to test out your sample and compare the build settings of your sample and my framework. Well, I have figured out what was the cause of the problem. I am happy I have resolved the issue, I should start to investigate your sample before digging into your code. Sorry, I did it in the late evening. |
Also, your script has a small issue: it places |
@GRyabkin Grand! Happy to hear your issue got resolved. |
"PRODUCT_NAME was misdefined:
MySDK
. Please, provide :product_name option"Error
The text was updated successfully, but these errors were encountered: