Fix problem with newline in vocab files

[JeanPaulShapo]

@ofrei

• this PR indents to fix vocab file in UCI bow require \n in the last line #519;
• new vocab file must be without the last newline;
• is it good idea to have identical code in src/artm/core/dicitonary.cc and src/artm/core/collection_parser.cc?

[ofrei]

Looks good!

[ofrei]

new vocab file must be without the last newline;

My assumption is that both formats are valid -- both with and without the last newline. Is this the case, or actually "new vocab file must be without the last newline;"?

[JeanPaulShapo]

@ofrei I crafted it to be without the last newline, and in test I checked both files - the old with newline and the new without newline - to ensure we handle both situations properly.
I hope no one will edit this file to add newline.

[ofrei]

Ah, I see - if you mean the new test file (test_data/vocab.parser_test_no_newline.txt) - sure, it must be without the new line. Thanks for adding a test for this!

[ofrei]

is it good idea to have identical code in src/artm/core/dicitonary.cc and src/artm/core/collection_parser.cc?

Yes, it's good to keep these two files consistent. Sad that they are copy-pasted like this.

[JeanPaulShapo]

I only wonder whether it's good idea to utilize this code in separate function
In that case we only need to fix bugs in one place.

[ofrei]

If you could refactor this code to avoid duplication - sure, that would be great.

[JeanPaulShapo]

Not in this PR.

[ofrei]

Agree)

[ofrei]

Sorry, I didn't put [PR:review OK]. You are welcome to fix any of the comments, but in either case this PR is good -- feel free to merge.

[JeanPaulShapo]

Whoops, I clicked the wrong button