Add a way to view a tag independently and list all values associated #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def verify_tag_page(tag) | ||
| within 'h2' do |
There was a problem hiding this comment.
Is this within the tag or is the actual text of the h2 tag? I try to avoid within tags when they are unnecessary.
page.should have_selector('h2', text: tag.name)
|
Looks good though overall I think the naming within this project is less than ideal. Mapped values and values is just really hard to understand. |
|
What would you suggest for naming ? I didn't like it either but at the time I came up empty |
|
I don't know the problem space really, I've not looked at the code in depth so I really can't provide solutions but it would be worth it for us to look at it soon or its going to continue to be had to understand. |
|
Alright sounds like a plan... atm it really isnt complicated but ill make an issue to refactor the mapped values model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22