Add delete function to mapped values #33
Conversation
|
Coverage increased (+0.12%) when pulling 5f7c6fb8b0030b53d20acc9595a7e16fd4e8c5af on bm-mapped-values-deleteable into eb8991b on master. |
| click_link 'Delete Value' | ||
| end | ||
|
|
||
| def verify_mapped_value_deleted |
There was a problem hiding this comment.
I dont know the best way to test that the value was deleted. shoudl just just check that the value is not in the table?
There was a problem hiding this comment.
Exactly. Make the value unique among the others and make sure it goes away. Leave the flash test as well if you care about flash.
There was a problem hiding this comment.
When i did that it stated that the value was not deleted for some reason.. but if i actually did it on the local server it did and the code deletes it from my understanding is there any way this could be cached or something weird?
There was a problem hiding this comment.
I'm guessing you're just not checking whatyou think you are. I'm sure there is no caching.
There was a problem hiding this comment.
Looking at your code again, I'm fairly certain that it is deleting properly, your test was probably just wrong. Try again 
, also this is fun 🚎
Closes #31