Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed UI issues in editor #68

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Fixed UI issues in editor #68

merged 5 commits into from
Dec 1, 2021

Conversation

AbhayVAshokan
Copy link
Member

Fixes #65.

  • Limited the height of the slash menu and added overflow-y: scroll.
  • Changed BubbleMenu tooltip placement to top-start.
  • Changed BubbleMenu z-index to appear above the neetoUI sidebar.
  • Added underline option to BubbleMenu.
  • Added highlight option to FixedMenu.

Please go through the following video: https://www.loom.com/share/7546a41921f7459f94ffc2d99a6cf472

@amaldinesh7
Copy link
Contributor

Screenshot 2021-12-01 at 5 56 55 PM

  • The button position is misaligned when the error message is showing
  • We can have dropdown for link input
  • Update the email validation regex

Please take up these in a separate issue

@AbhayVAshokan

@amaldinesh7 amaldinesh7 merged commit a7c1393 into master Dec 1, 2021
@amaldinesh7 amaldinesh7 deleted the 65-fix-ui-issues-in-editor branch December 1, 2021 13:06
@AbhayVAshokan AbhayVAshokan mentioned this pull request Dec 2, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amaldinesh7 amaldinesh7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI issues in editor
2 participants
@AbhayVAshokan @amaldinesh7